fix: share useBoxMetrics resize listener via emitLayoutListeners#952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently each instance of this hook adds a
stdout.on("resize"), quickly hitting the max listeners warning. This errors go throughprocess.emitWarning(), the ink console log patch doesn't catch it and they end up in the terminal output.A workaround is bumping the max listeners, but I think a better fix is just sharing a single listener. This change simply emits a layout change on resize. Looks like only
useBoxMetricsis usingaddLayoutListeners, so it shouldn't affect any other hooks.Errors look like this: