Update focus handling in App component to conditionally reset on Escape#937
Merged
sindresorhus merged 1 commit intoApr 14, 2026
Merged
Conversation
…cape key press based on focus state
pabloelisseo
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are disabiling focus control with:
and the start of our CLI because we want manually manage the tab, shift-tab and escape, but while this is effective to disable the automaticaly handling of tab, it is still messing with the escape, leaving the application on a broken state where nothing is focused.
Notice that, in our use case we still wanna use useFocus(), it's a nice abstraction to coordinate focus, and pass it around, we just don't want the "automated" tab/shift-tab/escape handling