Skip to content

Update focus handling in App component to conditionally reset on Escape#937

Merged
sindresorhus merged 1 commit into
vadimdemedes:masterfrom
manucorporat:fix-escape-focus-disabled
Apr 14, 2026
Merged

Update focus handling in App component to conditionally reset on Escape#937
sindresorhus merged 1 commit into
vadimdemedes:masterfrom
manucorporat:fix-escape-focus-disabled

Conversation

@manucorporat

@manucorporat manucorporat commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

We are disabiling focus control with:

  const { disableFocus} = useFocusManager();

and the start of our CLI because we want manually manage the tab, shift-tab and escape, but while this is effective to disable the automaticaly handling of tab, it is still messing with the escape, leaving the application on a broken state where nothing is focused.

Notice that, in our use case we still wanna use useFocus(), it's a nice abstraction to coordinate focus, and pass it around, we just don't want the "automated" tab/shift-tab/escape handling

@sindresorhus sindresorhus merged commit cb66873 into vadimdemedes:master Apr 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants