Skip to content

feat: add AbstractLogin.showErrorMessage()#5749

Merged
sissbruecker merged 10 commits intomainfrom
feat/1525
Jan 11, 2024
Merged

feat: add AbstractLogin.showErrorMessage()#5749
sissbruecker merged 10 commits intomainfrom
feat/1525

Conversation

@mvysny
Copy link
Copy Markdown
Member

@mvysny mvysny commented Nov 21, 2023 •
edited by sissbruecker
Loading

Description

Adds AbstractLogin.showErrorMessage() which allows you to set the login error message programmatically, when implementing custom authentication flow.

Fixes #1525

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.
  • I have not completed some of the steps above and my pull request can be closed immediately.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@mvysny mvysny requested a review from web-padawan November 22, 2023 17:15
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mcollovati mcollovati removed their request for review November 29, 2023 08:52
@yuriy-fix
Copy link
Copy Markdown
Contributor

yuriy-fix commented Dec 5, 2023

We will proceed with the PR after branching out for new minor. (~ couple of weeks)

@vursen vursen changed the title feat: Add AbstractLogin.setErrorMessage(). Fixes #1525 [24.4] feat: Add AbstractLogin.setErrorMessage(). Fixes #1525 Dec 12, 2023
@vursen vursen changed the title [24.4] feat: Add AbstractLogin.setErrorMessage(). Fixes #1525 feat: Add AbstractLogin.setErrorMessage(). Fixes #1525 (24.4) Dec 12, 2023
@vursen vursen changed the title feat: Add AbstractLogin.setErrorMessage(). Fixes #1525 (24.4) feat: Add AbstractLogin.setErrorMessage(). Fixes #1525 Dec 20, 2023
@sissbruecker sissbruecker requested review from sissbruecker and removed request for web-padawan January 11, 2024 12:57
@sissbruecker sissbruecker changed the title feat: Add AbstractLogin.setErrorMessage(). Fixes #1525 feat: add AbstractLogin.showErrorMessage() Jan 11, 2024
@sissbruecker sissbruecker enabled auto-merge (squash) January 11, 2024 13:24
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sissbruecker sissbruecker merged commit 7e21fcb into main Jan 11, 2024
@sissbruecker sissbruecker deleted the feat/1525 branch January 11, 2024 13:32
@vaadin-bot
Copy link
Copy Markdown
Collaborator

vaadin-bot commented Jan 12, 2024

This ticket/PR has been released with Vaadin 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@web-padawan web-padawan web-padawan left review comments

@sissbruecker sissbruecker sissbruecker approved these changes

Assignees

No one assigned

Labels

prerelease version for Vaadin 24.4.0 Released with Vaadin 24.4.0.alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New API for setting error title and message directly

6 participants

@mvysny @yuriy-fix @vaadin-bot @sissbruecker @web-padawan @brunovianarezende