Skip to content

feat: add ComboBox.setOverlayWidth() and MultiSelectComboBox.setOverlayWidth()#5743

Merged
sissbruecker merged 7 commits intomainfrom
feat/2331
Jan 15, 2024
Merged

feat: add ComboBox.setOverlayWidth() and MultiSelectComboBox.setOverlayWidth()#5743
sissbruecker merged 7 commits intomainfrom
feat/2331

Conversation

@mvysny
Copy link
Copy Markdown
Member

@mvysny mvysny commented Nov 21, 2023 •
edited by sissbruecker
Loading

Description

Add ComboBox.setOverlayWidth() and MultiSelectComboBox.setOverlayWidth() which allow to control the dropdown width from server-side Java code.

Fixes #2331

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.
  • I have not completed some of the steps above and my pull request can be closed immediately.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@sissbruecker sissbruecker removed their request for review November 23, 2023 13:27
@mvysny mvysny requested a review from yuriy-fix November 28, 2023 13:36
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yuriy-fix
Copy link
Copy Markdown
Contributor

yuriy-fix commented Dec 5, 2023

We will proceed with the PR after branching out for new minor. (~ couple of weeks)

@vursen vursen changed the title feat: add ComboBox.setDropdownWidth() and MultiSelectComboBox.setDropdownWidth() [24.4] feat: add ComboBox.setDropdownWidth() and MultiSelectComboBox.setDropdownWidth() Dec 12, 2023
@vursen vursen changed the title [24.4] feat: add ComboBox.setDropdownWidth() and MultiSelectComboBox.setDropdownWidth() feat: add ComboBox.setDropdownWidth() and MultiSelectComboBox.setDropdownWidth() (24.4) Dec 12, 2023
@sissbruecker
Merge branch 'main' into feat/2331
de643a2 
# Conflicts:
#	vaadin-combo-box-flow-parent/vaadin-combo-box-flow/src/test/java/com/vaadin/flow/component/combobox/MultiSelectComboBoxTest.java
@sissbruecker
align test names
cbfddc8
@sissbruecker sissbruecker changed the title feat: add ComboBox.setDropdownWidth() and MultiSelectComboBox.setDropdownWidth() (24.4) feat: add ComboBox.setOverlayWidth() and MultiSelectComboBox.setOverlayWidth() Jan 15, 2024
@sissbruecker sissbruecker enabled auto-merge (squash) January 15, 2024 13:52
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 15, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sissbruecker sissbruecker merged commit a337f0f into main Jan 15, 2024
@sissbruecker sissbruecker deleted the feat/2331 branch January 15, 2024 14:03
@vaadin-bot
Copy link
Copy Markdown
Collaborator

vaadin-bot commented Jan 18, 2024

This ticket/PR has been released with Vaadin 24.4.0.alpha2 and is also targeting the upcoming stable 24.4.0 version.

@web-padawan web-padawan mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sissbruecker sissbruecker sissbruecker approved these changes

@web-padawan web-padawan Awaiting requested review from web-padawan

@mgarciavaadin mgarciavaadin Awaiting requested review from mgarciavaadin

@yuriy-fix yuriy-fix Awaiting requested review from yuriy-fix

Assignees

No one assigned

Labels

prerelease version for Vaadin 24.4.0 Released with Vaadin 24.4.0.alpha2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

API for setting dropdown popup overlay width

4 participants

@mvysny @yuriy-fix @vaadin-bot @sissbruecker