test: use Jetty EMBED for IDE debugging, FORK for CI#23416
Merged
Conversation
|
e209542 to
2d8fe4f
Compare
Jetty uses SLF4J 2.x fluent logging APIs (e.g., `atDebug()`) that are not available in the legacy SLF4J 1.x implementation provided by Maven's classloader. This can potentially cause `NoSuchMethodError` when running Jetty in EMBED mode. See jetty/jetty.project#14435 FORK mode isolates Jetty in a separate JVM with its own classloader, avoiding the conflict between Maven's legacy SLF4J and Jetty's SLF4J 2.x requirements. This change moves FORK-specific Jetty config (`deployMode`, `jvmArgs`, `maxChildStartChecks`, `maxChildStartCheckMs`) from plugin-level configuration to the `start-jetty` execution only. This way `mvn jetty:run` uses EMBED mode (debuggable from IDE), while `mvn verify` still uses FORK mode (avoids SLF4J classloader conflict).
2d8fe4f to
c819c76
Compare
caalador
reviewed
Mar 12, 2026
mcollovati
commented
Mar 12, 2026
caalador
approved these changes
Mar 12, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jetty uses SLF4J 2.x fluent logging APIs (e.g.,
atDebug()) thatare not available in the legacy SLF4J 1.x implementation provided by
Maven's classloader. This can potentially cause
NoSuchMethodErrorwhen running Jetty in EMBED mode.
See jetty/jetty.project#14435
FORK mode isolates Jetty in a separate JVM with its own classloader,
avoiding the conflict between Maven's legacy SLF4J and Jetty's SLF4J 2.x
requirements.
This change moves FORK-specific Jetty config (
deployMode,jvmArgs,maxChildStartChecks,maxChildStartCheckMs) from plugin-levelconfiguration to the
start-jettyexecution only. This waymvn jetty:runuses EMBED mode (debuggable from IDE), whilemvn verifystill uses FORK mode (avoids SLF4J classloader conflict).