Merged
Conversation
a9e9103 to
cf53671
Compare
camillobruni
approved these changes
Apr 4, 2024
Contributor
camillobruni
left a comment
There was a problem hiding this comment.
LGTM (let's add the prettierc in a separate PR)
Contributor
Author
Thanks! I'll open another PR about formatting :) |
Contributor
Author
|
@camillobruni If there aren’t any major issues, how about merging it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
debug footer line break issue
issue : #694
changes :
margin-leftofdark-mode-toggle:1emto0.15emfont-sizeofnav:16pxto15pxI've changed
margin-leftvalue ofdark-mode-toggleto0.15emandfont-sizeof anchor tag in#footer navto15pxso that the letter 'light' and 'dark' can be in the same line until819px.The layout changes when the width is under
818px. So i think it would be better if there's no line break until819px.So it works on my code!
Before
(over
860px)After
(over
860px, it maintains the same line until819px)