Skip to content

numfmt: use succeeds()/fails() instead of run() in tests#7135

Merged
sylvestre merged 1 commit intouutils:mainfrom
cakebaker:numfmt_replace_run
Jan 14, 2025
Merged

numfmt: use succeeds()/fails() instead of run() in tests#7135
sylvestre merged 1 commit intouutils:mainfrom
cakebaker:numfmt_replace_run

Conversation

@cakebaker
Copy link
Copy Markdown
Contributor

@cakebaker cakebaker commented Jan 14, 2025

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 14, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/misc/stdbuf is no longer failing!
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre
Copy link
Copy Markdown
Contributor

sylvestre commented Jan 14, 2025

i wonder if we could prevent this coding pattern...

@sylvestre sylvestre merged commit 1ffb6fd into uutils:main Jan 14, 2025
@cakebaker cakebaker deleted the numfmt_replace_run branch January 15, 2025 06:14
@cakebaker
Copy link
Copy Markdown
Contributor Author

cakebaker commented Jan 15, 2025

I think it is mainly a copy & paste issue. In a future PR I will replace run() in the other tests where possible.

@moonfruit moonfruit mentioned this pull request Jan 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cakebaker @sylvestre