tsort: split edge data on any whitespace chars#7078
Merged
cakebaker merged 3 commits intouutils:mainfrom Jan 5, 2025
Merged
Conversation
Make `tsort` split on any whitespace character instead of just
whitespace within a single line. This allows edge information to be
split with the source node on one line and the target node on another.
For example, after this commit
$ printf "a\nb\n" | tsort
a
b
whereas before this would print an error message.
Closes uutils#7077
|
GNU testsuite comparison: |
Contributor
|
A much cleaner approach, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
tsortsplit on any whitespace character instead of justwhitespace within a single line. This allows edge information to be
split with the source node on one line and the target node on another.
For example, after this commit
whereas before this would print an error message.
This pull request also makes two other small changes. First, it introduces a
TsortErrorenum implementing theUErrortrait to represent the various problems thattsortmight encounter. Second, it uses the standard librarystd::io::read_to_stringandstd::fs::read_to_stringin place of custom code that was ultimately doing the same thing.Closes #7077