Skip to content

GnuComment: zizmor: ignore[dangerous-triggers]#6974

Merged
sylvestre merged 1 commit intouutils:mainfrom
dcampbell24:zizmor-fix-00
Dec 19, 2024
Merged

GnuComment: zizmor: ignore[dangerous-triggers]#6974
sylvestre merged 1 commit intouutils:mainfrom
dcampbell24:zizmor-fix-00

Conversation

@dcampbell24
Copy link
Copy Markdown
Contributor

This looks like a false positive.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@sylvestre
Copy link
Copy Markdown
Contributor

maybe it should be reported to upstream as a bug

@sylvestre sylvestre merged commit db332e5 into uutils:main Dec 19, 2024
@woodruffw
Copy link
Copy Markdown

woodruffw commented Dec 19, 2024

FWIW, this is not a false positive: the impact is low in your case, but any third-party fork can declare a new foo.yml with name: GnuTests and trigger your workflow in an upstream context.

(In your case the attacker can run a workflow with upstream repo credentials, which they can then use to submit an arbitrary comment/contents as if it was your normal "testsuite comparison" response. This is pretty low-impact, but it's probably not something you intended 🙂)

@dcampbell24
Copy link
Copy Markdown
Contributor Author

Thanks for the information! If we were going to fix this what would we do?

@dcampbell24 dcampbell24 deleted the zizmor-fix-00 branch December 19, 2024 20:44
@woodruffw
Copy link
Copy Markdown

My recommendation would be to switch from workflow_run to workflow_call -- there are some recommendations and links here: https://woodruffw.github.io/zizmor/audits/#remediation_1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants