seq:reduce memory allocation during prefix search#6949
Merged
cakebaker merged 1 commit intouutils:mainfrom Dec 11, 2024
Merged
Conversation
This improvement eliminates extra memory allocations during the search for 0x/0X prefixes in number strings.
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed that the code in the
numberparsemodule tries to work without extra memory allocations. However, one place withto_lowercasebreaks the general approach.So, I slightly updated that part to match the common pattern.
Please feel free just to close the PR if this change seems unimportant or a preliminary optimization.
Thank you