Merged
Conversation
6c0ff65 to
3137bd3
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
9d2578d to
3c6079f
Compare
|
GNU testsuite comparison: |
Contributor
|
would it be possible to replicate this test on our side? thanks |
dd fix gnu test not-rewound.sh
|
GNU testsuite comparison: |
563226a to
3de43ad
Compare
Contributor
Author
|
@sylvestre test added. ready for review. :-) |
|
GNU testsuite comparison: |
sylvestre
reviewed
Mar 17, 2024
| @@ -0,0 +1,83 @@ | |||
| // This file is part of the uutils coreutils package. | |||
Contributor
There was a problem hiding this comment.
could you please document it?
As it will be part of the API like:
https://docs.rs/uucore/0.0.24/uucore/error/index.html
Contributor
Author
There was a problem hiding this comment.
thats cool.
I added some documentation.
Thanks.
this is important as the fd holds the file offset we need to use
3de43ad to
4057717
Compare
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.