`dd`: unset O_DIRECT flag on last chunk if irregular sized by cre4ture · Pull Request #6080 · uutils/coreutils

cre4ture · 2024-03-15T16:52:11Z

addresses #6078 (detailed, please read)

github-actions · 2024-03-15T17:28:57Z

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

sylvestre · 2024-03-15T17:32:39Z

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

nice :)

github-actions · 2024-03-15T19:31:06Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/dd/direct is no longer failing!

sylvestre · 2024-03-16T11:07:31Z

is it possible to add a test for this? thanks

cre4ture · 2024-03-16T16:52:45Z

sure. I can do that.
But I have a general question:
Is the gnu test enough? Or should we ensure that each functionality that the GNU test-suite validates is also validated by our own test suite?

github-actions · 2024-03-17T17:10:03Z

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/timeout/timeout is no longer failing!

sylvestre · 2024-03-17T17:50:34Z

Is the gnu test enough? Or should we ensure that each functionality that the GNU test-suite validates is also validated by our own test suite?

We want to test it with own first. It is much faster to run ours. And way easier to hack.

github-actions · 2024-03-17T19:23:38Z

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/timeout/timeout is no longer failing!

github-actions · 2024-03-17T20:45:53Z

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/timeout/timeout is no longer failing!

sylvestre · 2024-03-17T22:04:53Z

could you please rebase this PR? thanks

cre4ture · 2024-03-18T22:24:02Z

I will rebase it. But the tests on android are not yet green. Merging needs to wait...

github-actions · 2024-03-18T23:00:18Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions · 2024-03-19T00:37:26Z

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

this way the retry can re-use previously build results

github-actions · 2024-04-25T21:56:58Z

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions · 2024-04-28T11:11:19Z

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions · 2024-04-28T11:37:25Z

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions · 2024-04-28T14:44:03Z

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions · 2024-04-28T15:30:21Z

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions · 2024-04-28T17:05:47Z

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions · 2024-04-28T18:47:33Z

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/dd/direct is no longer failing!

github-actions · 2024-04-28T19:26:08Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/dd/direct is no longer failing!

…t_sh # Conflicts: # Cargo.toml

github-actions · 2024-04-30T20:22:08Z

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

# Conflicts: # Cargo.toml

github-actions · 2024-05-01T20:28:06Z

GNU testsuite comparison:

Congrats! The gnu test tests/dd/direct is no longer failing!

cre4ture changed the title ~~unset O_DIRECT flag on last chunk if irregular sized~~ dd: unset O_DIRECT flag on last chunk if irregular sized Mar 15, 2024

cre4ture force-pushed the fix/gnu_test_dd_direct_sh branch from 2b38f71 to 4e54ba9 Compare March 15, 2024 16:59

cre4ture force-pushed the fix/gnu_test_dd_direct_sh branch from 4e54ba9 to 944f36a Compare March 15, 2024 19:03

cre4ture force-pushed the fix/gnu_test_dd_direct_sh branch 2 times, most recently from b586180 to b1986d0 Compare March 17, 2024 16:34

cre4ture force-pushed the fix/gnu_test_dd_direct_sh branch from b1986d0 to f6266b8 Compare March 17, 2024 18:55

cre4ture force-pushed the fix/gnu_test_dd_direct_sh branch from f6266b8 to 3b61dbd Compare March 17, 2024 20:16

cre4ture force-pushed the fix/gnu_test_dd_direct_sh branch from 3b61dbd to 41bb74f Compare March 18, 2024 22:32

cre4ture force-pushed the fix/gnu_test_dd_direct_sh branch from 6065e55 to c649e69 Compare March 18, 2024 23:54

cre4ture marked this pull request as draft March 19, 2024 20:49

cre4ture mentioned this pull request Mar 20, 2024

test_od - re-enable f16 test with newer AVD system image #6099

Merged

cre4ture added 3 commits April 25, 2024 23:11

unset O_DIRECT flag on last chunk if irregular sized

b7fad0b

unset direct mode also for read if needed

ae5014d

bump android api level 30 (android os 11)

ba3fe6f

cre4ture force-pushed the fix/gnu_test_dd_direct_sh branch from a0cda49 to ba3fe6f Compare April 25, 2024 21:12

set CARGO_TARGET_DIR env variable for cargo install step

fb61c01

this way the retry can re-use previously build results

cre4ture added 3 commits April 28, 2024 12:17

add ufs filesystem

9c8609d

add debug logs

a509775

fix dd issue when reading from /dev/random with fullblock option

e558f3b

cre4ture added 4 commits April 28, 2024 14:07

fmt

3e14901

adapt freebsd zfs numbers to new rounding

d8bcc5b

logging framework first draft

0297968

fix wrong order of dropping

899d1d5

cre4ture added 2 commits April 28, 2024 16:51

framework is fully functional

ef563fe

enable logs for more tests

d537411

cre4ture added 3 commits April 28, 2024 18:06

fix zfs tests

aac48d1

improve logging

2a01ce4

fix freebsd UFS

1c21b65

cre4ture added 4 commits April 28, 2024 20:00

replace dd with own implementation for creating a file with size

ee8beb3

fix android 10

29038d3

fmt

39f2053

activate android 11

3b6a753

cre4ture added 3 commits April 30, 2024 20:13

activate old, working android version

da444fc

add logs for dd

039ef96

Merge remote-tracking branch 'uutils/main' into fix/gnu_test_dd_direc…

910d33f

…t_sh # Conflicts: # Cargo.toml

Merge branch 'main' into fix/gnu_test_dd_direct_sh

57439c8

# Conflicts: # Cargo.toml

cre4ture closed this Sep 14, 2024

Uh oh!

Conversation

cre4ture commented Mar 15, 2024

Uh oh!

github-actions bot commented Mar 15, 2024

Uh oh!

sylvestre commented Mar 15, 2024

Uh oh!

github-actions bot commented Mar 15, 2024

Uh oh!

sylvestre commented Mar 16, 2024

Uh oh!

cre4ture commented Mar 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 17, 2024

Uh oh!

sylvestre commented Mar 17, 2024

Uh oh!

github-actions bot commented Mar 17, 2024

Uh oh!

github-actions bot commented Mar 17, 2024

Uh oh!

sylvestre commented Mar 17, 2024

Uh oh!

cre4ture commented Mar 18, 2024

Uh oh!

github-actions bot commented Mar 18, 2024

Uh oh!

github-actions bot commented Mar 19, 2024

Uh oh!

github-actions bot commented Apr 25, 2024

Uh oh!

github-actions bot commented Apr 28, 2024

Uh oh!

github-actions bot commented Apr 28, 2024

Uh oh!

github-actions bot commented Apr 28, 2024

Uh oh!

github-actions bot commented Apr 28, 2024

Uh oh!

github-actions bot commented Apr 28, 2024

Uh oh!

github-actions bot commented Apr 28, 2024

Uh oh!

github-actions bot commented Apr 28, 2024

Uh oh!

github-actions bot commented Apr 30, 2024

Uh oh!

github-actions bot commented May 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cre4ture commented Mar 16, 2024 •

edited

Loading