pr: Check the correct timestamp in test_with_pr_core_utils_tests#6010
Merged
tertsdiepraam merged 1 commit intouutils:mainfrom Feb 25, 2024
Merged
Conversation
Collaborator
|
Whoa, great job finding the issue here! Seeing the CI green is so nice! |
Contributor
|
+1! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
test_pr::test_with_pr_core_utils_testsis flaky, and causes real problems.Here's a branch that makes the bug 100% reproducible, by injecting "lag" at critical moments: https://github.com/BenWiederhake/coreutils-rs/tree/historic/demo-pr-test-race
The bug is best explained by the fix:
let input_file_path = input_file.first().unwrap(); let test_file_path = expected_file.first().unwrap(); - let value = file_last_modified_time(&scenario, test_file_path); + let value = file_last_modified_time(&scenario, input_file_path); let mut arguments: Vec<&str> = …; arguments.extend(input_file.clone()); // "value" is then used to construct the expected output.In other words:
valueis the last modified time of the wrong file.All other tests in
test_prseem to use the correct file, so this should fix this issue for good.