Skip to content

shuf: Do not read input when -n0 is given#5990

Merged
cakebaker merged 1 commit intouutils:mainfrom
BenWiederhake:dev-shuf-head-null
Feb 23, 2024
Merged

shuf: Do not read input when -n0 is given#5990
cakebaker merged 1 commit intouutils:mainfrom
BenWiederhake:dev-shuf-head-null

Conversation

@BenWiederhake
Copy link
Copy Markdown
Collaborator

This is explicitly tested by some suites, including the GNU test suite.

Together with #5980 and #5989, this should make uutils pass the GNU test suite for shuf. Yay! :D

@sylvestre
Copy link
Copy Markdown
Contributor

please run rustfmt :)

@BenWiederhake
Copy link
Copy Markdown
Collaborator Author

Changes since last push:

  • Rebased on new main
  • Re-ran rustfmt, thanks @sylvestre! (I deactivated due to the rustc ICE a few days ago, and forgot to re-enable it)
  • Simplified the "no output" test, thanks @cakebaker!
  • Added a comment in the test, just to make extra clear that this is intentional.

@BenWiederhake
Copy link
Copy Markdown
Collaborator Author

Changes since last push:

  • Added "unwritable" to the cspell-ignore header.
  • test_cp::test_cp_arg_interactive_update flaked. No action taken.

This is explicitly tested by some suites, including the GNU test suite.
@BenWiederhake
Copy link
Copy Markdown
Collaborator Author

Changes since last push:

  • Rebased on current main
  • Simplified a few tests by calling .no_output(). Thanks @cakebaker!
  • Split test_zero_head_count_file_touch_output into three tests: Negative (tries to write to unwritable path), positive (new file created), another positive (touches existing file). Thanks @cakebaker!

@cakebaker cakebaker merged commit 5a2e0c7 into uutils:main Feb 23, 2024
@cakebaker
Copy link
Copy Markdown
Contributor

Good job, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants