ci:android stabilize and improve android github actions#5939
Merged
cakebaker merged 1 commit intouutils:mainfrom Feb 4, 2024
Merged
ci:android stabilize and improve android github actions#5939cakebaker merged 1 commit intouutils:mainfrom
ci:android stabilize and improve android github actions#5939cakebaker merged 1 commit intouutils:mainfrom
Conversation
Contributor
Author
|
@cakebaker sorry, I didn't know that you are also working on it |
Collaborator
|
Cool! I'm not an expert on this, but it looks good and if it improves the Android CI, I'm all for it. |
ci:android stabilize and improve android github actions
Contributor
Author
Thanks. |
Contributor
|
LGTM. I just would like @cakebaker to review it too as he worked on this recently too. |
Collaborator
Sylvestre, cakebaker and me and we're all involved already so this has priority! :) |
Contributor
|
Great job, thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did the following changes which make the build significantly more robust:
All the testing took quite some time. I did't spend more time for splitting this change into smaller peaces. Hope this is fine.
Both android builds are currently red due to failing tests. For two of them I have fixes, but I will create new PRs for those: #5821 and #5940