Skip to content

Clippy suggestions#5895

Merged
sylvestre merged 5 commits intouutils:mainfrom
kralo:clippy-suggestions
Jan 28, 2024
Merged

Clippy suggestions#5895
sylvestre merged 5 commits intouutils:mainfrom
kralo:clippy-suggestions

Conversation

@kralo
Copy link
Copy Markdown
Contributor

@kralo kralo commented Jan 27, 2024

ran clippy with clippy::range-plus-one, clippy::redundant-closure-for-method-calls and fix those where I was confident this is

a) improvement to the reader
b) does not make lines longer, no additional imports

@sylvestre
Copy link
Copy Markdown
Contributor

sylvestre commented Jan 28, 2024

could you please update the CI to run these too ?
https://github.com/uutils/coreutils/blob/main/.github/workflows/code-quality.yml#L124

@kralo
Copy link
Copy Markdown
Contributor Author

kralo commented Jan 28, 2024

I left open what should happen with extremely long redundant closures.

Cases like these,

warning: redundant closure
   --> src/uu/tail/src/args.rs:197:22
    |
197 |                 .map(|s| s.as_str()),
    |                      ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `std::string::String::as_str`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls
    = note: requested on the command line with `-W clippy::redundant-closure-for-method-calls`

To my eyes, std::string::String::as_str is neither more readable, nor shorter.

@kralo
Copy link
Copy Markdown
Contributor Author

kralo commented Jan 28, 2024

could you please update the CI to run these too ? https://github.com/uutils/coreutils/blob/main/.github/workflows/code-quality.yml#L124

done for the trivial ones currently passing

@kralo kralo force-pushed the clippy-suggestions branch from 2b2b584 to 886d273 Compare January 28, 2024 08:01
kralo added 5 commits January 28, 2024 09:42
@kralo @sylvestre
nl: fix redundant clone (clippy warning)
bd43a7e
@kralo @sylvestre
uucore: remove unneccessary closues
9906e66 
This adresses only those where the fix has less letters than the
original and is "trivial" (There are possibly a lot of std::string::ToString::to_string
and those may only be shortened with additional imports).

Found with clippy::redundant-closure-for-method-calls
@kralo @sylvestre
split: use inclusive range
d046d33 
as suggested by clippy::range-plus-one
@kralo @sylvestre
cp: use inclusive range
ee7f99a 
as suggested by clippy::range-plus-one
@kralo @sylvestre
ci: include more clippy complaints
43212c6
@sylvestre sylvestre merged commit 3362d8a into uutils:main Jan 28, 2024
@sylvestre
Copy link
Copy Markdown
Contributor

sylvestre commented Jan 28, 2024

thanks :)

@chenrui333 chenrui333 mentioned this pull request Mar 24, 2024
Merged
@moonfruit moonfruit mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kralo @sylvestre