Skip to content

util: android disable mirror selection#5894

Merged
sylvestre merged 2 commits intouutils:mainfrom
kralo:android-buildscript
Jan 28, 2024
Merged

util: android disable mirror selection#5894
sylvestre merged 2 commits intouutils:mainfrom
kralo:android-buildscript

Conversation

@kralo
Copy link
Copy Markdown
Contributor

@kralo kralo commented Jan 27, 2024

this is what {termux}/scripts/termux-change-repo.in does at the end

this is an attemp at fixing #5893 which tries an unreachable mirror

@kralo kralo force-pushed the android-buildscript branch 6 times, most recently from 14cbbec to 58995fa Compare January 27, 2024 22:40
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 27, 2024

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@kralo kralo force-pushed the android-buildscript branch 2 times, most recently from c2630e4 to c4e6368 Compare January 27, 2024 23:35
@kralo kralo changed the title util: android setup add pkg --check-mirror util: android disable mirror selection Jan 27, 2024
@kralo
Copy link
Copy Markdown
Contributor Author

kralo commented Jan 27, 2024

disabling mirror detection.
the shipped version of pkg in the image is so broken that it does not detect one mirror as broken, and subsequent package loading fails.

@kralo kralo force-pushed the android-buildscript branch from c4e6368 to 8dbce58 Compare January 27, 2024 23:47
@kralo
Copy link
Copy Markdown
Contributor Author

kralo commented Jan 28, 2024

to explain this better: this PR improves android image generation/termux installation,

and the !5896 is for the test, that apparently is now running on android


--- TRY 3 STDERR:        coreutils::tests test_cp::test_cp_preserve_xattr_fails_on_android ---
thread 'test_cp::test_cp_preserve_xattr_fails_on_android' panicked at tests/by-util/test_cp.rs:1466:10:
Command was expected to fail.
stdout = 
 stderr = 
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

@sylvestre
Copy link
Copy Markdown
Contributor

sylvestre commented Jan 28, 2024

excellent, thanks
could you please disable test_cp_preserve_xattr_fails_on_android as ride along ?

@kralo kralo force-pushed the android-buildscript branch from 8dbce58 to 5dccfc2 Compare January 28, 2024 07:56
@kralo kralo mentioned this pull request Jan 28, 2024
Closed
@sylvestre
Copy link
Copy Markdown
Contributor

sylvestre commented Jan 28, 2024

image

sweet!

@sylvestre sylvestre merged commit 8772eb6 into uutils:main Jan 28, 2024
@kralo kralo mentioned this pull request Jan 28, 2024
Closed
@chenrui333 chenrui333 mentioned this pull request Mar 24, 2024
Merged
@moonfruit moonfruit mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kralo @sylvestre