Skip to content

tsort: returns error when input is dir - same as GNU tsort#5860

Merged
cakebaker merged 5 commits intouutils:mainfrom
SaHHiiLL:main
Jan 19, 2024
Merged

tsort: returns error when input is dir - same as GNU tsort#5860
cakebaker merged 5 commits intouutils:mainfrom
SaHHiiLL:main

Conversation

@SaHHiiLL
Copy link
Copy Markdown
Contributor

fix: #5853

@cakebaker
Copy link
Copy Markdown
Contributor

Can you please add a test so we don't regress in the future?

@SaHHiiLL
Copy link
Copy Markdown
Contributor Author

sure!

@SaHHiiLL
Copy link
Copy Markdown
Contributor Author

lmk if there's something else I can put instead of . for the test

@cakebaker
Copy link
Copy Markdown
Contributor

I think . is fine.

If you want to specify a concrete directory name, you can use something like:

let (at, mut ucmd) = at_and_ucmd!();
at.mkdir("dirname");

And then use ucmd instead of new_ucmd!.

@SaHHiiLL
Copy link
Copy Markdown
Contributor Author

Alright, That seems to work. Thanks for the help!!

@cakebaker cakebaker merged commit 746a7b1 into uutils:main Jan 19, 2024
@cakebaker
Copy link
Copy Markdown
Contributor

Thanks for your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tsort: show error if directory is specified

2 participants