Closed
Conversation
954cbd8 to
dd201d2
Compare
Contributor
Author
|
CI/CD reported +15.46% testcoverage for nohup.rs :-) |
dd201d2 to
385c719
Compare
385c719 to
37fbdf3
Compare
Contributor
|
I don't know whether you have seen that the test fails on FreeBSD/macOS? |
Contributor
Author
thanks for pointing out. there are so many unrelated error currently that it gets difficult to see the real issues |
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
This was referenced Jan 20, 2024
Contributor
Author
|
it seems that the improvements done in #5869 helped to solve the issue with FreeBSD. I guess it's the spawning of reader threads for the master side of the pty output. So I would then close this pull request, if the other gets accepted. |
c43d85e to
4f47ed2
Compare
Contributor
Author
|
closed in favor of #5869 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as requested in #1857
I was able to simulate a terminal such that we can test the code in function "replace_fds"
EDIT: this PR is probably replaced by this: #5869