Skip to content

printf : no infinite loop#5830

Merged
cakebaker merged 3 commits intouutils:mainfrom
sudhackar:printf-infinite-loop
Jan 12, 2024
Merged

printf : no infinite loop#5830
cakebaker merged 3 commits intouutils:mainfrom
sudhackar:printf-infinite-loop

Conversation

@sudhackar
Copy link
Copy Markdown
Contributor

@sudhackar sudhackar commented Jan 12, 2024

Fixes #5815

$ printf a b
a

This PR adds a test for this behaviour. at this moment - the iter from parse_spec_and_escape function won't consume args if no format string is present and goes to an infinite loop.

coreutils/src/uu/printf/src/printf.rs

Lines 49 to 54 in edb77b8

while args.peek().is_some() {
for item in parse_spec_and_escape(format_string.as_ref()) {
match item?.write(stdout(), &mut args)? {
ControlFlow::Continue(()) => {}
ControlFlow::Break(()) => return Ok(()),
};

@sudhackar
Copy link
Copy Markdown
Contributor Author

sudhackar commented Jan 12, 2024 •
edited
Loading

failures seem unrelated - "https://busybox.net/downloads/busybox-1.35.0.tar.bz2" is timing out and some issues with termux apt get.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 12, 2024

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

tertsdiepraam
tertsdiepraam reviewed Jan 12, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Seems correct to me and with a nice test. I just have a small suggestion.

@cakebaker cakebaker merged commit 7e3f4d8 into uutils:main Jan 12, 2024
@cakebaker
Copy link
Copy Markdown
Contributor

cakebaker commented Jan 12, 2024

Thanks for your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tertsdiepraam tertsdiepraam tertsdiepraam left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

printf: infinite loop

3 participants

@sudhackar @cakebaker @tertsdiepraam