Merged
Conversation
Using `saturating_sub()` before converting to `usize` gives a wrong feeling of security as it looks like it ensures that the value will never go negative. However, since it is applied to `i32`, it can, and converting it to `usize` would go horribly wrong anyway. By following the code flow, `exponent` cannot be greater than `precision`, or the `else` block would not have been taken. A plain subtraction will give the same result and will at least panic in debug mode.
`seq --format %.2g 10 10` would display `1` because the precision would not allow room for the decimal point, and the `0` in `10` would be trimmed as an insignificant trailing `0`. This has been fixed by only trimming trailing `0` in the presence of a decimal point.
5b23e5a to
32f0256
Compare
Contributor
Author
|
I've added some tests as well |
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output of
seqhad two issues:%gwas set to 0 instead of 60.Fix #5766