cksum: Add --length argument for the blake2b algorithm#5749
Merged
cakebaker merged 9 commits intouutils:mainfrom Dec 30, 2023
DitherWither:main
Merged
cksum: Add --length argument for the blake2b algorithm#5749cakebaker merged 9 commits intouutils:mainfrom DitherWither:main
cakebaker merged 9 commits intouutils:mainfrom
DitherWither:main
Conversation
cakebaker
reviewed
Dec 30, 2023
Contributor
cakebaker
left a comment
There was a problem hiding this comment.
Looks good.
There are two special cases of length values that are currently not covered and lead to a panic: 0 and lengths > 512 that are divisible by 8.
Author
|
Ok, I handled those values, and also added tests for the same |
Contributor
|
Great job, thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should close #5707
This adds the
--length(short form-l) option, along with unit tests for itIt allows you to specify the output digest size for the
blake2balgorithm