Skip to content

cp: backup dest symlink linking to source#5739

Merged
sylvestre merged 2 commits intouutils:mainfrom
cakebaker:cp_backup_with_symlink_to_source
Jan 14, 2024
Merged

cp: backup dest symlink linking to source#5739
sylvestre merged 2 commits intouutils:mainfrom
cakebaker:cp_backup_with_symlink_to_source

Conversation

@cakebaker
Copy link
Copy Markdown
Contributor

This PR covers a special case of #5731, with the destination being a symlink to the source. So far this caused a "same file" error whereas it works fine with GNU cp.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker force-pushed the cp_backup_with_symlink_to_source branch from 593773e to 7bd2074 Compare December 31, 2023 13:20
 is_forbidden_copy_to_same_file -> is_forbidden_to_copy_to_same_file
@cakebaker cakebaker force-pushed the cp_backup_with_symlink_to_source branch from 7bd2074 to 902a128 Compare December 31, 2023 13:36
@sylvestre sylvestre merged commit 36039a8 into uutils:main Jan 14, 2024
@cakebaker cakebaker deleted the cp_backup_with_symlink_to_source branch January 15, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants