uucore: remove useless conversion for features/fs on OpenBSD#5676
Merged
sylvestre merged 1 commit intouutils:mainfrom Dec 20, 2023
Merged
uucore: remove useless conversion for features/fs on OpenBSD#5676sylvestre merged 1 commit intouutils:mainfrom
sylvestre merged 1 commit intouutils:mainfrom
Conversation
- src/uucore/src/lib/features/fs.rs: in inode function, remove useless
conversion for target_OS = OpenBSD
Signed-off-by: Laurent Cheylus <foxy@free.fr>
Contributor
|
It would really nice to add openbsd in the CI :) |
Contributor
Author
I'm working on OpenBSD CI, job "Style and Lint" is OK => see https://github.com/lcheylus/rust-coreutils/actions/runs/7251920664 I found this issue with this workflow for OpenBSD. |
Contributor
|
merci! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build and tests OK on OpenBSD/amd64 and Linux
Tests with inodes (via
ls) on OpenBSD => same results with Rust and system coreutils