Skip to content

ls: ignore invalid block size from env vars#5674

Merged
sylvestre merged 1 commit intouutils:mainfrom
cakebaker:ls_ignore_invalid_block_size_from_env_vars
Dec 19, 2023
Merged

ls: ignore invalid block size from env vars#5674
sylvestre merged 1 commit intouutils:mainfrom
cakebaker:ls_ignore_invalid_block_size_from_env_vars

Conversation

@cakebaker
Copy link
Copy Markdown
Contributor

If the block size value specified by an env variable (e.g. LS_BLOCK_SIZE) is invalid, GNU ls "ignores" the value (it changes a block size value we currently don't have) whereas uutils ls panics while creating an error. This PR fixes this issue.

@cakebaker cakebaker force-pushed the ls_ignore_invalid_block_size_from_env_vars branch from 0291b30 to a560661 Compare December 19, 2023 09:02
@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate

@sylvestre sylvestre merged commit 3d42619 into uutils:main Dec 19, 2023
@cakebaker cakebaker deleted the ls_ignore_invalid_block_size_from_env_vars branch December 19, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants