tests/hostname: disable failing test_hostname::test_hostname_ip on OpenBSD#5639
Merged
sylvestre merged 1 commit intouutils:mainfrom Dec 16, 2023
Merged
tests/hostname: disable failing test_hostname::test_hostname_ip on OpenBSD#5639sylvestre merged 1 commit intouutils:mainfrom
sylvestre merged 1 commit intouutils:mainfrom
Conversation
…enBSD
- On OpenBSD, test_hostname::test_hostname_ip fails with "failed to lookup address information:
Name does not resolve" error
Signed-off-by: Laurent Cheylus <foxy@free.fr>
Contributor
|
do you know why it is doing that ? |
Contributor
Author
|
Because implementation for There is a note in if matches.get_flag(OPT_IP_ADDRESS) {
// XXX: to_socket_addrs needs hostname:port so append a dummy port and remove it later.
// This was originally supposed to use std::net::lookup_host, but that seems to be
// deprecated. Perhaps we should use the dns-lookup crate?Maybe this reverse DNS resolution for IP addr should be implemented otherwise on all OS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On OpenBSD, test_hostname::test_hostname_ip fails with "failed to lookup address information: Name does not resolve" error