Merged
Conversation
|
GNU testsuite comparison: |
cakebaker
reviewed
Dec 7, 2023
src/uu/du/src/du.rs
Outdated
| convert_size, | ||
| }) | ||
| fn new(options: PrintingOptions, summarize: bool) -> UResult<Self> { | ||
| Ok(Self { summarize, options }) |
Contributor
There was a problem hiding this comment.
Suggested change
| Ok(Self { summarize, options }) | |
| Ok(Self { options, summarize }) |
cakebaker
reviewed
Dec 7, 2023
src/uu/du/src/du.rs
Outdated
Comment on lines
+562
to
+570
| for &(unit, power) in &UNITS { | ||
| let limit = multiplier.pow(power); | ||
| if size >= limit { | ||
| return format!("{:.1}{}", (size as f64) / (limit as f64), unit); | ||
| } | ||
| } | ||
| if size == 0 { | ||
| return "0".to_string(); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| for &(unit, power) in &UNITS { | |
| let limit = multiplier.pow(power); | |
| if size >= limit { | |
| return format!("{:.1}{}", (size as f64) / (limit as f64), unit); | |
| } | |
| } | |
| if size == 0 { | |
| return "0".to_string(); | |
| } | |
| if size == 0 { | |
| return "0".to_string(); | |
| } | |
| for &(unit, power) in &UNITS { | |
| let limit = multiplier.pow(power); | |
| if size >= limit { | |
| return format!("{:.1}{}", (size as f64) / (limit as f64), unit); | |
| } | |
| } |
cakebaker
reviewed
Dec 7, 2023
Contributor
cakebaker
left a comment
There was a problem hiding this comment.
Looks good. Thanks for getting rid of those convert_size_* functions.
7cc73b0 to
7861559
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: nushell/nushell#11040 (comment)
Just some general cleanup of
du:ArgMatchesaround but put everything in the options structsThere's more to do, but it's a start :)