split: passing GNU test r-chunk.sh#5580
Merged
sylvestre merged 3 commits intouutils:mainfrom Nov 28, 2023
Merged
Conversation
414d7c3 to
7b2a3e2
Compare
|
GNU testsuite comparison: |
Contributor
Author
|
@sylvestre @tertsdiepraam would you mind taking a look at this one? It should complete |
Contributor
|
terrific, bravo :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass GNU test tests/split/r-chunk.sh
Implement handling system limit on open files (
ulimit -n) following the same approach as in GNU split, i.e. running up to the limit, catch an error on instantiating next writer to a file, closing one of the existing writers to free up resources and re-trying to instantiate a writer again, including tracking new vs. append to previously created and closed writers.Tests.