libstdbuf: remove crash macro#5565
Conversation
There was a problem hiding this comment.
This is however a bit of a tricky crate. Since this crate is injected into processes, I think it might actually best if this doesn't rely on uucore. In this case I think we should just check what error messages GNU gives and just use eprintln! and std::process::exit to match that.
@sylvestre do you agree?
Edit: Actually, I think we should probably only print a warning if we fail to parse the value.
|
Added some changes, including no longer relying on |
1761a7d to
0db8fbb
Compare
|
GNU testsuite comparison: |
tertsdiepraam
left a comment
There was a problem hiding this comment.
Great! Just one small question
tertsdiepraam
left a comment
There was a problem hiding this comment.
Great! Let's also remove the uucore dependency in src/uu/stdbuf/src/libstdbuf/Cargo.toml!
|
Ah right, thanks :D |
This PR is related to issue: #5487
Removes the
crash!macro from libstdbuf