Skip to content

expand: remove crash! macro#5510

Merged
cakebaker merged 4 commits intouutils:mainfrom
ceteece:expand-remove-crash-macro
Nov 10, 2023
Merged

expand: remove crash! macro#5510
cakebaker merged 4 commits intouutils:mainfrom
ceteece:expand-remove-crash-macro

Conversation

@ceteece
Copy link
Copy Markdown
Contributor

@ceteece ceteece commented Nov 7, 2023

Related issue: #5487

Removes use of crash! macro in expand

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 8, 2023

GNU testsuite comparison:

Congrats! The gnu test tests/tail/symlink is no longer failing!

@ceteece ceteece marked this pull request as ready for review November 9, 2023 05:03
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 9, 2023

GNU testsuite comparison:

GNU test failed: tests/tail/symlink. tests/tail/symlink is passing on 'main'. Maybe you have to rebase?

Copy link
Copy Markdown
Collaborator

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! One tiny suggestion, otherwise ready to be merged!

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/tail/truncate. tests/tail/truncate is passing on 'main'. Maybe you have to rebase?

@cakebaker cakebaker merged commit 7202d01 into uutils:main Nov 10, 2023
@cakebaker
Copy link
Copy Markdown
Contributor

Thanks for your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants