ls: fix symlink chain target coloring #10274
Open
+39
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
Collaborator
Author
|
Doing a bit more research and theres another pre-existing bug that colors for file extensions is not working, I think there should be a simple fix too but will add some integration tests for that use case too. |
7054d7c to
c0b8d66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was reviewing this PR #9006 I tried to do some fuzzing of the existing implementation to see if the PR was implementing any behaviour that was missing and came across that the ls utility was matching all of GNU's coloring except for on nested symlinks.
When looking at what that was the case I saw that it was just a three line fix when compared to the the current implementation