I've been a little bit confused with this issue. I know that mkfifo.rs has its integration test scripts in tests/by-util/test_mkfifo.rs and that it needs a feature like --feature=feat_os_unix set for it to run. The integration test scripts for mkfifo looks like it should already cover a good chunk or all of the code within mkfifo.rs.

So far, I've checked out the CICD.yaml and noticed that the coverage script is ran through ./util/build-run-test-coverage.sh, which has the feature --features=feat_os_unix set. My understanding of what ./util/build-run-test-coverage.sh is that it runs each util test from tests/by-util/*. I've taken a look at where UTIL_LIST comes from here:

#shellcheck disable=SC2086
UTIL_LIST=$("${ME_dir}"/show-utils.sh ${FEATURES_OPTION})

...

for UTIL in ${UTIL_LIST}; do

    run_test_and_aggregate \
        "${UTIL}" \
        "-p coreutils -E test(/^test_${UTIL}::/) ${FEATURES_OPTION}"

    echo "## Clear the trace directory to free up space"
    rm -rf "${PROFRAW_DIR}" && mkdir -p "${PROFRAW_DIR}"
done;

When I took a look at show-utils.sh from util/show-utils.sh, it seems like we either get all the utils provided by feat_os_unix only if we have the jq command installed; otherwise if jq doesn't exists, we're given the Tier 1 utility list, which doesn't have certain utils like mkfifo, stat, nice, nohup, etc.

The last thing I took a look at to verify if the integration tests (which it appears to be) are actually running is to see what CICD.yaml is reporting in GitHub action for the main branch. What I'm noticing from this report for mkfifo.rs is this however:

 Nextest run ID 6b3a573e-6650-4c8a-a69a-3e4608e0f15a with nextest profile: coverage
    Starting 9 tests across 5 binaries (4354 tests skipped)
        PASS [   0.055s] (1/9) coreutils::tests test_mkfifo::test_create_fifo_missing_operand
        PASS [   0.057s] (2/9) coreutils::tests test_mkfifo::test_create_multiple_fifos
        PASS [   0.073s] (3/9) coreutils::tests test_mkfifo::test_create_fifo_with_umask
        PASS [   0.065s] (4/9) coreutils::tests test_mkfifo::test_create_one_fifo
        PASS [   0.064s] (5/9) coreutils::tests test_mkfifo::test_create_one_fifo_already_exists
        PASS [   0.072s] (6/9) coreutils::tests test_mkfifo::test_create_one_fifo_with_invalid_mode
        PASS [   0.065s] (7/9) coreutils::tests test_mkfifo::test_create_one_fifo_with_mode
        PASS [   0.050s] (8/9) coreutils::tests test_mkfifo::test_invalid_arg
        PASS [   0.307s] (9/9) coreutils::tests test_mkfifo::test_create_fifo_with_mode_and_umask
────────────
     Summary [   0.316s] 9 tests run: 9 passed, 4354 skipped
## Tests for (mkfifo) generated 352M of profraw files
## Aggregating coverage files under /home/runner/work/coreutils/coreutils/coverage/data/mkfifo.profdata
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
0  libLLVM.so.21.1-rust-1.93.0-nightly 0x00007f3fb6a50647 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 39
1  libLLVM.so.21.1-rust-1.93.0-nightly 0x00007f3fb6a50f3d
2  libc.so.6                           0x00007f3fb1045330
3  llvm-profdata                       0x000055740c7c6bf5
4  llvm-profdata                       0x000055740c7c6b61
5  llvm-profdata                       0x000055740c7cdfeb
6  llvm-profdata                       0x000055740c7d5b24
7  llvm-profdata                       0x000055740c7d55f8
8  llvm-profdata                       0x000055740c7d5561
9  libc.so.6                           0x00007f3fb10a1ed3
10 llvm-profdata                       0x000055740c7d5524
11 llvm-profdata                       0x000055740c7d5481
12 llvm-profdata                       0x000055740c7d590a
13 llvm-profdata                       0x000055740c7d5aad
14 libLLVM.so.21.1-rust-1.93.0-nightly 0x00007f3fb6a17af0 llvm::StdThreadPool::processTasks(llvm::ThreadPoolTaskGroup*) + 480
15 libLLVM.so.21.1-rust-1.93.0-nightly 0x00007f3fb6a18b8f
16 libc.so.6                           0x00007f3fb109caa4
17 libc.so.6                           0x00007f3fb1129c6c
./util/build-run-test-coverage-linux.sh: line 65: 25445 Illegal instruction     (core dumped) "${LLVM_PROFDATA}" merge -sparse -o ${PROFDATA_FILE} ${PROFRAW_DIR}/*.profraw
## Clear the trace directory to free up space

There's an error that occurs at this part of ./util/build-run-test-coverage.sh:

    # Aggregate all the trace files into a profdata file
    PROFDATA_FILE="${PROFDATA_DIR}/${1}.profdata"
    echo "## Aggregating coverage files under ${PROFDATA_FILE}"
    "${LLVM_PROFDATA}" merge \
        -sparse \
        -o ${PROFDATA_FILE} \
        ${PROFRAW_DIR}/*.profraw \
    || true
    # We don't want an error in `llvm-profdata` to abort the whole program

I can see why coverage is not being reported to Codecov as a result of not having the coverage file for these tests, but I'm having a hard time figuring out what's causing this error or how to resolve it.

Also, one more thing, should this be happening for running uucore tests?:

Running coverage tests over uucore
# Running coverage tests for uucore
   Compiling selinux-sys v0.6.15
   Compiling uucore v0.4.0 (/home/runner/work/coreutils/coreutils/src/uucore)
warning: building proc macro crate with `panic=abort` or `panic=immediate-abort` may crash the compiler should the proc-macro panic

warning: `uucore_procs` (lib) generated 1 warning
   Compiling selinux v0.5.2
error: linking with `cc` failed: exit status: 1
...
...
error: could not compile `uucore` (lib test) due to 1 previous error
error: command `/home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/cargo test --no-run --message-format json-render-diagnostics --package uucore --all-features` exited with code 101
## Tests for (uucore) generated 8.4M of profraw files
## Aggregating coverage files under /home/runner/work/coreutils/coreutils/coverage/data/uucore.profdata
# Aggregating all the profraw files under /home/runner/work/coreutils/coreutils/coverage/report/total.lcov.info
steps.run_test_cov.outputs.REPORT_FILE=

^Seen on the CICD report in GitHub action for main branch.

Uh oh!

mkfifo.rs: improve code coverage #9059

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions