Stable 2.39/bcachefs fixes#2505
Conversation
Probing does not detect bcachefs filesystems with a superblock larger than 4KiB. Bcachefs superblocks grow in size and can become much larger than this. Increase the superblock maximum size limit to 1MiB. Validate the superblock isn't larger than the maximum size defined in the superblocks layout section. (cherry picked from commit 48d5737)
Addresses: util-linux#2427 Signed-off-by: Karel Zak <kzak@redhat.com> (cherry picked from commit 17873d3)
Avoid signed shift out-of-bounds. Also mark the constants explitly as unsigned instead of casting. Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de> (cherry picked from commit befe455)
|
@t-8ch thanks so much! will this be a 2.39.3 release? |
|
@YellowOnion That's for @karelzak to decide and do. |
I did a |
|
So encrypted bcachefs support is broken independently of these fixes? |
|
@t-8ch doesn't seem related to be bcachefs, it's the https://gitlab.com/cryptsetup/cryptsetup/-/blob/v2.6.1/tests/compat-test?ref_type=tags#L237 |
|
@t-8ch actually this has nothing to do with the patches, a vanilla compile triggers this on my system. I don't know why shrug |
|
I'd prefer to postpone the release of version 2.39.3 a bit longer to collect more bug fixes, possibly until around October 15th. |
|
@karelzak all good, I've included the current patch in NixOS for now. |
|
Are the patches all in? With bcachefs in 6.7-rc* it would be awesome for all the distros to start getting a new release of blkid in preparation for 6.7 final. |
I guess there are a lot of fixes in master which would make sense to include. |
|
bcachefs is now in testing / RC, might be good to try and finalize |
|
@karelzak It's not strictly a bugfix, but why not. |
It sounds like you want to send PR :-) |
Fixes #2501