Skip to content

Stable 2.39/bcachefs fixes#2505

Merged
karelzak merged 3 commits intoutil-linux:stable/v2.39from
t-8ch:stable-2.39/bcachefs-fixes
Sep 25, 2023
Merged

Stable 2.39/bcachefs fixes#2505
karelzak merged 3 commits intoutil-linux:stable/v2.39from
t-8ch:stable-2.39/bcachefs-fixes

Conversation

@t-8ch
Copy link
Copy Markdown
Member

@t-8ch t-8ch commented Sep 22, 2023

Fixes #2501

breavyn and others added 3 commits September 22, 2023 20:47
Probing does not detect bcachefs filesystems with a superblock larger
than 4KiB. Bcachefs superblocks grow in size and can become much larger
than this.

Increase the superblock maximum size limit to 1MiB.

Validate the superblock isn't larger than the maximum size defined in
the superblocks layout section.

(cherry picked from commit 48d5737)
Addresses: util-linux#2427
Signed-off-by: Karel Zak <kzak@redhat.com>
(cherry picked from commit 17873d3)
Avoid signed shift out-of-bounds.

Also mark the constants explitly as unsigned instead of casting.

Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
(cherry picked from commit befe455)
@karelzak karelzak merged commit 6b9fda8 into util-linux:stable/v2.39 Sep 25, 2023
@YellowOnion
Copy link
Copy Markdown

@t-8ch thanks so much! will this be a 2.39.3 release?

@t-8ch
Copy link
Copy Markdown
Member Author

t-8ch commented Sep 26, 2023

@YellowOnion That's for @karelzak to decide and do.
I would guess that it will happen but don't know when.
Also some other fixes should probably go into it.

@YellowOnion
Copy link
Copy Markdown

@YellowOnion That's for @karelzak to decide and do.
I would guess that it will happen but don't know when.
Also some other fixes should probably go into it.

I did a git show on the three patches and applied it, seems to rebuild fine, just waiting on the entire system to rebuild due to NixOS's pedantic versioning, crypt setup not passing tests tho hmm.

@t-8ch
Copy link
Copy Markdown
Member Author

t-8ch commented Sep 26, 2023

So encrypted bcachefs support is broken independently of these fixes?
This was not clear to me.

@YellowOnion
Copy link
Copy Markdown

@t-8ch doesn't seem related to be bcachefs, it's the cryptsetup test suite that fails with the new util-linux:

CASE: Image in file tests (root capabilities not required)
[1] format
[2] open
Device wipe error, offset 1810432.
Cannot wipe header on device luks-header.
FAILED backtrace:
237 ./compat-test
FAIL: compat-test

https://gitlab.com/cryptsetup/cryptsetup/-/blob/v2.6.1/tests/compat-test?ref_type=tags#L237

@YellowOnion
Copy link
Copy Markdown

@t-8ch actually this has nothing to do with the patches, a vanilla compile triggers this on my system. I don't know why shrug

@karelzak
Copy link
Copy Markdown
Collaborator

I'd prefer to postpone the release of version 2.39.3 a bit longer to collect more bug fixes, possibly until around October 15th.

@YellowOnion
Copy link
Copy Markdown

@karelzak all good, I've included the current patch in NixOS for now.

@phedders
Copy link
Copy Markdown

Are the patches all in? With bcachefs in 6.7-rc* it would be awesome for all the distros to start getting a new release of blkid in preparation for 6.7 final.

@karelzak
Copy link
Copy Markdown
Collaborator

It's merged but not released. We can release v2.39.3; it's unusual to have a .3 release, but why not ...

There is also some libmount fix; maybe we can add something more to the release. @t-8ch and @masatake, any suggestion for another stable release?

@t-8ch
Copy link
Copy Markdown
Member Author

t-8ch commented Nov 14, 2023

any suggestion for another stable release

I guess there are a lot of fixes in master which would make sense to include.
At least the recent stuff for sparc64 and also some older stuff.

@t-8ch t-8ch deleted the stable-2.39/bcachefs-fixes branch November 14, 2023 10:39
@t-8ch
Copy link
Copy Markdown
Member Author

t-8ch commented Nov 14, 2023

Also fixes for #2528 and #2576 would make sense IMO.

@YellowOnion
Copy link
Copy Markdown

bcachefs is now in testing / RC, might be good to try and finalize .3 soon.

@karelzak
Copy link
Copy Markdown
Collaborator

@t-8ch do we need also da91337 in stable/v2.39 branch?

@t-8ch
Copy link
Copy Markdown
Member Author

t-8ch commented Nov 24, 2023

@karelzak It's not strictly a bugfix, but why not.
There are also a bunch of other bugfixes on master that probably should be backported.

@karelzak
Copy link
Copy Markdown
Collaborator

@karelzak It's not strictly a bugfix, but why not. There are also a bunch of other bugfixes on master that probably should be backported.

It sounds like you want to send PR :-)

@t-8ch t-8ch mentioned this pull request Nov 25, 2023
@phedders
Copy link
Copy Markdown

@t-8ch do we need also da91337 in stable/v2.39 branch?

Yes that would be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants