Skip to content

Improvements to build process and build on 12.1EE image#1185

Merged
jgebal merged 17 commits intodevelopfrom
feature/publish_test_results_in_pr
Feb 11, 2022
Merged

Improvements to build process and build on 12.1EE image#1185
jgebal merged 17 commits intodevelopfrom
feature/publish_test_results_in_pr

Conversation

@jgebal
Copy link
Copy Markdown
Member

@jgebal jgebal commented Feb 6, 2022 •
edited
Loading

  1. Separated install steps for better visibility & clarity.
  • install
  • check code style (11g)
  • uninstall and validate uninstall completeness (on 11g)
  • reinstall (11g)
  1. Fixed the uninstall validation (didn't work)
  2. Added diagnostic data upload (as build artefact) on failed tests (as our builds sometimes fail with ORA-600) and I asked @gvenzl for help with diagnostics
  3. Added 12.1EE private image to have coverage for testing on 12.1 version and on EE.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 6, 2022 •
edited
Loading

Unit Test Results

       1 files         2 suites   1m 45s ⏱️
1 029 tests 1 025 ✔️ 4 💤 0 ❌
1 032 runs  1 024 ✔️ 8 💤 0 ❌

Results for commit af0b0bb.

♻️ This comment has been updated with latest results.

@jgebal jgebal force-pushed the feature/publish_test_results_in_pr branch 3 times, most recently from 9d2ab26 to 2f29162 Compare February 7, 2022 21:06
jgebal added 2 commits February 8, 2022 00:14
@jgebal
Reorganizing install scripts to make the code-style chech, uninstall …
2a0b2c9 
…validate, create test users and reinstall steps explicit in deployment pipeline
@jgebal
Adding and testing diagnostics steps
07fcf35
@jgebal jgebal force-pushed the feature/publish_test_results_in_pr branch from 9c9c33f to 07fcf35 Compare February 7, 2022 23:34
@jgebal jgebal force-pushed the feature/publish_test_results_in_pr branch from b4beaa4 to 610067f Compare February 8, 2022 01:15
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 8, 2022 •
edited
Loading

Codecov Report

Merging #1185 (af0b0bb) into develop (62716ae) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1185      +/-   ##
===========================================
+ Coverage    94.77%   94.79%   +0.02%     
===========================================
  Files          104      104              
  Lines         4878     4878              
  Branches        22       22              
===========================================
+ Hits          4623     4624       +1     
  Misses         247      247              
+ Partials         8        7       -1
Flag Coverage Δ
11XE 94.22% <ø> (?)
11xe ?
12.1EE 94.26% <ø> (?)
18XE 94.41% <ø> (?)
18xe ?
21XE 94.59% <ø> (?)
21xe ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/core/ut_utils.pkb 94.44% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c91c7b...af0b0bb. Read the comment docs.

@jgebal jgebal force-pushed the feature/publish_test_results_in_pr branch from c9307c7 to cb64865 Compare February 8, 2022 23:04
@jgebal jgebal changed the title Testing reporting of failing tests in branch and PR builds. Improvements to build process and build on 12.1EE image Feb 10, 2022
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jgebal jgebal merged commit 8b53736 into develop Feb 11, 2022
@jgebal jgebal deleted the feature/publish_test_results_in_pr branch February 13, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jgebal