Added missing test for multiple expectation failures with exception thrown.

jgebal · jgebal · commit 73e9cf32bce4 · 2023-04-27T22:09:18.000+03:00
diff --git a/test/ut3_user/reporters.pkb b/test/ut3_user/reporters.pkb
@@ -90,11 +90,10 @@ as
 
   procedure erroring_test
   is
-    l_variable integer;
+    l_integer_variable integer;
   begin
     dbms_output.put_line('<!erroring test!>');
-    l_variable := 'a string';
-    ut3_develop.ut.expect(l_variable).to_equal(1);
+    l_integer_variable := 'a string';
   end;
 
   procedure disabled_test
diff --git a/test/ut3_user/reporters/test_teamcity_reporter.pkb b/test/ut3_user/reporters/test_teamcity_reporter.pkb
@@ -36,6 +36,9 @@ create or replace package body test_teamcity_reporter as
 
       --%test
       procedure multi_failure;
+
+      --%test
+      procedure multi_failure_on_error;
     end;]';
       execute immediate q'[create or replace package body check_multiple_failures is
       procedure multi_failure is
@@ -44,6 +47,14 @@ create or replace package body test_teamcity_reporter as
         ut3_develop.ut.expect(2).to_equal(1);
         ut3_develop.ut.expect('Bad').to_equal('Good');
       end;
+      procedure multi_failure_on_error is
+        l_integer_variable integer;
+      begin
+        ut3_develop.ut.expect(1).to_be_null;
+        ut3_develop.ut.expect(2).to_equal(1);
+        ut3_develop.ut.expect('Bad').to_equal('Good');
+        l_integer_variable := 'a string';
+      end;
     end;]';
 
     end;
@@ -132,7 +143,7 @@ create or replace package body test_teamcity_reporter as
     ut.expect(ut3_tester_helper.main_helper.table_to_clob(l_output_data)).to_be_like(l_expected);
   end;
 
-  procedure report_mutiple_expectations is
+  procedure report_multiple_expectations is
     l_output_data       ut3_develop.ut_varchar2_list;
     l_expected          varchar2(32767);
   begin
@@ -146,7 +157,29 @@ create or replace package body test_teamcity_reporter as
     --act
     select *
         bulk collect into l_output_data
-    from table(ut3_develop.ut.run('check_multiple_failures',ut3_develop.ut_teamcity_reporter()));
+    from table(ut3_develop.ut.run('check_multiple_failures.multi_failure',ut3_develop.ut_teamcity_reporter()));
+
+    --assert
+    ut.expect(ut3_tester_helper.main_helper.table_to_clob(l_output_data)).to_be_like(l_expected);
+  end;
+
+  procedure report_multiple_expect_on_err is
+    l_output_data       ut3_develop.ut_varchar2_list;
+    l_expected          varchar2(32767);
+  begin
+    l_expected := q'{%##teamcity[testSuiteStarted timestamp='%' name='check_multiple_failures']
+%##teamcity[testStarted timestamp='%' captureStandardOutput='true' name='ut3_user.check_multiple_failures.multi_failure_on_error']
+%##teamcity[testStdErr timestamp='%' name='ut3_user.check_multiple_failures.multi_failure_on_error' out='Test exception:|nORA-06502: PL/SQL: %: character to number conversion error|nORA-06512: at "UT3_USER.CHECK_MULTIPLE_FAILURES", line %|nORA-06512: at %|n']
+%##teamcity[testFailed timestamp='%' details='Test exception:|nORA-06502: PL/SQL: %: character to number conversion error|nORA-06512: at "UT3_USER.CHECK_MULTIPLE_FAILURES", line %|nORA-06512: at %|n' message='Error occured' name='ut3_user.check_multiple_failures.multi_failure_on_error']
+%##teamcity[testFailed timestamp='%' details='Actual: 1 (number) was expected to be null' name='ut3_user.check_multiple_failures.multi_failure_on_error']
+%##teamcity[testFailed timestamp='%' details='Actual: 2 (number) was expected to equal: 1 (number)' name='ut3_user.check_multiple_failures.multi_failure_on_error']
+%##teamcity[testFailed timestamp='%' details='Actual: |'Bad|' (varchar2) was expected to equal: |'Good|' (varchar2)' name='ut3_user.check_multiple_failures.multi_failure_on_error']
+%##teamcity[testFinished timestamp='%' duration='%' name='ut3_user.check_multiple_failures.multi_failure_on_error']
+%##teamcity[testSuiteFinished timestamp='%' name='check_multiple_failures']}';
+    --act
+    select *
+        bulk collect into l_output_data
+    from table(ut3_develop.ut.run('check_multiple_failures.multi_failure_on_error',ut3_develop.ut_teamcity_reporter()));
 
     --assert
     ut.expect(ut3_tester_helper.main_helper.table_to_clob(l_output_data)).to_be_like(l_expected);
diff --git a/test/ut3_user/reporters/test_teamcity_reporter.pks b/test/ut3_user/reporters/test_teamcity_reporter.pks
@@ -16,7 +16,10 @@ create or replace package test_teamcity_reporter as
   procedure trims_long_output;
 
   --%test(Reports failures on multiple expectations)
-  procedure report_mutiple_expectations;
+  procedure report_multiple_expectations;
+
+  --%test(Reports failures on multiple expectations)
+  procedure report_multiple_expect_on_err;
 
   --%afterall
   procedure remove_test_package;
