USWDS-Site - Changelog: Modal body padding [#5493]#2273
Merged
Conversation
This was referenced Sep 12, 2023
mahoneycm
reviewed
Sep 18, 2023
| - date: NNNN-NN-NN | ||
| summary: Updated how the modal JavaScript resets body padding and improved body padding detection. | ||
| summaryAdditional: Now the component will rely on the CSS to reset body padding rather than injecting an inline style with JavaScript. | ||
| affectsJavascript: true |
Contributor
There was a problem hiding this comment.
Should we add the affectsStyles tag as welll?
mahoneycm
approved these changes
Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add changelog entry for modal body padding fix.
Related PR
uswds/uswds#5493
Preview link
Modal changelog