USWDS - Core: Replace receptor library "ignore" with Element#contains#6173
Merged
heymatthenry merged 1 commit intoJun 9, 2025
Merged
Conversation
Contributor
|
Looking into it, it looks like this might be a relic of the old components structure? Here's a link to the components dir from the release-2.14.0 branch. I also can't find where this JS file is being used at all. This looks like a suitable replacement but I'm curious if we should just remove from this version of USWDS since it's not being used by the design system. @amyleadem @mejiaj Any thoughts? Should we upkeep despite this or is it just tech debt? |
|
@mlloydbixal Adding you as a reviewer for this to get us unblocked on #6291 |
heymatthenry
approved these changes
Jun 9, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduced the JavaScript bundle size. By optimizing the implementation of core component code, overall JavaScript sizes are reduced.
Breaking change
This is not a breaking change.
Related pull requests
Split from #5793, to simplify review.
Preview link
N/A
Problem statement
See #5793
Solution
Replace use of
receptor/ignorewith equivalentNode#containscondition.The intended purpose is the same.
receptor.ignore:Node#containsTesting and review
To be totally honest, I'm not sure what this behavior is meant to control. References to
js-search-buttonCSS class do not appear in any relevant Storybook stories or documentation.