USWDS - Memorable Date: Remove numbers from the dropdown list of months#6028
Conversation
mejiaj
left a comment
There was a problem hiding this comment.
Confirming I can navigate using keyboard more easily. Thanks Cathy!
uswds-memorable-date-6028.webm
mahoneycm
left a comment
There was a problem hiding this comment.
Searching by name is working for me! I think this will clear up a lot of the confusion.
Thanks @cathybaptista !
There was a problem hiding this comment.
Thanks for making this update @cathybaptista. The code update looks good!
Quick request before approval: Can you update the summary in the PR description to be a bit more succinct? We try to pull that PR summary into the release notes and the current one is a bit too long to be useful in that context. If desired, we can move the additional information that is currently in the "summary" section down to the "solution" section.
I'm thinking something like this should work (Feel free to edit):
Removed the leading numbers from the month options in the memorable date component. Recent usability testing indicated that having both numbers and names to represent months was confusing for screen reader users.
|
Oh, one more thought: I believe we wouldn't mark this as a breaking change in the description, since nothing will technically break if the user doesn't change anything. Instead, we mark this as just a markup change. See the release notes for examples of other non-breaking markup changes. |
|
Moving the original issue back to |
There was a problem hiding this comment.
Looks good to me! Thanks @cathybaptista
Moved the issue to FFR
Summary
Removed the leading numbers from the month options in the memorable date component. Recent usability testing indicated that having both numbers and names to represent months was confusing for screen reader users.
Breaking change
This is not a breaking change.
Related issue
Closes #5910
Related pull requests
Changelog uswds/uswds-site#2787
Preview link
Preview link: Memorable Date preview
Problem statement
The desired state for the memorable date component is that there is only one option for the values in the months dropdown (either numbers or month names) so that users can search by typing in the month name. The current state is that both the number and the month name are included in the option dropdown, which means users cannot search by the month name.
Solution
The solution is to remove the numbers from the memorable date component option dropdown. Another approach was to make both options (numbers AND month names) available, but the risk of this approach did not outweigh the rewards. The team decided that including month names is the best way to resolve this accessibility issue.
Testing and review