USWDS: Add autocomplete attribute to email inputs#6002
Merged
Conversation
- This allows inputs to meet criteria for wcag 1.3.5
amycole501
approved these changes
Jul 31, 2024
alex-hull
approved these changes
Jul 31, 2024
mahoneycm
approved these changes
Aug 1, 2024
mahoneycm
left a comment
Contributor
There was a problem hiding this comment.
LGTM! I didn't notice any behavior or screen reader changes across browsers.
Contributor
|
chore (non-blocking): Once this is merged, we'll need to remove the |
3 tasks
thisisdano
approved these changes
Oct 3, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added the
autocomplete="email"attribute to the email input element in both the big footer and the "Create an account" template. This attribute allows the components to meet the standards outlined in WCAG 1.3.5.Breaking change
This is not a breaking change.
This is a markup change.
Related issue
Closes #6001
Related pull requests
Changelog PR
Preview link
Problem statement
The email input in the big footer variant needs the autocomplete="email" attribute in order to meet WCAG criteria 1.3.5.
Solution
Added the
autocompleteattribute to the inputs with anemailtype.Testing and review
type="email"have theautocomplete="email"attribute