USWDS - Tooltip: Create a mixin for the tooltip spacer#5933
Merged
Conversation
mahoneycm
reviewed
May 20, 2024
| /// Create a spacer to increase target area for tooltip triangle. | ||
| /// | ||
| /// @param {String} $direction - The direction of the tooltip; can be top, bottom, left, right. | ||
| /// @param {Length} $triangle-size [5px] - The size of the triangle. |
Contributor
There was a problem hiding this comment.
Is it correct to define $triangle-size as a parameter here even though it's not being passed into the mixin?
Contributor
Author
There was a problem hiding this comment.
That's a good point. I don't think it's necessary since triangle size is already customizable.
I've moved the variable above the mixin in 04dcd6b to make it clearer that this mixin relies on that.
amyleadem
approved these changes
May 20, 2024
amyleadem
left a comment
Contributor
There was a problem hiding this comment.
Thanks for taking this on @mejiaj! I confirmed that this mixin positions the spacers correctly (See screenshot below. Note: spacers are highlighted in orange only for demonstration purposes). The code looks great and is easy to understand.
The `$triangle-size` variable isn't a parameter, so removed from SASSDoc comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Created mixin for tooltip spacer to avoid duplicate code.
Breaking change
This is not a breaking change.
Related issue
#5918
Related pull requests
Related to #5919.
Preview link
Preview link: Tooltip →
Problem statement
The CSS for creating the tooltip spacer was repetitive.
Solution
Created a mixin to manage this in one place.
Testing and review
Tooltips should create a spacer element between trigger and body that keeps the content visible.