USWDS - Footer: Restore layout-grid dependency#5930
Merged
Conversation
This was referenced May 15, 2024
amyleadem
approved these changes
May 16, 2024
amyleadem
left a comment
Contributor
There was a problem hiding this comment.
Looks good! I checked the following:
mejiaj
approved these changes
May 17, 2024
thisisdano
approved these changes
May 22, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restored layout-grid dependency in footer package and removed layout-grid styles from footer stylesheet. This update prevents visual regression in other components with layout-grid utility classes in their markup.
Breaking change
This is not a breaking change.
Related issue
Closes #5914
Related pull requests
Changelog →
USWDS - Footer: Remove grid dependency.#5289
USWDS - Footer: Grid layout hotfix#5675
Preview link
Footer storybook preview →
Problem statement
The styles we added to footer after removing the layout-grid dependency cause visual regressions in other components with layout-grid utility classes in their markup.
Solution
Due to the amount of layout-grid classes used in footer markup, we’ve decided it’s best to include the dependency moving forward.
Major changes
layout-griddependency in footer packagelayout-gridclasses in footer stylesheetTesting and review
usa-layout-gridpackage._usa-footer.scssto the release-3.7.0 version (before we removed the dependency) and confirm they match.