USWDS - In-page navigation: Update reference to data-heading-elements sttribute#5856
Merged
Conversation
- data-header-selector is now called data-heading-elements in the system
mahoneycm
approved these changes
Apr 10, 2024
mahoneycm
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! Searched for any references to data-header-selector and didn't find any 👍
mejiaj
approved these changes
Apr 18, 2024
mejiaj
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Didn't find any references on here or site.
thisisdano
approved these changes
May 22, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated an outdated reference to the
data-header-selectorattribute in an in-page navigation JavaScript error message. The error message now correctly references thedata-heading-elementsattribute.Breaking change
This is not a breaking change.
Related issue
Closes #5836
Related pull requests
N/A
Preview link
N/A
Problem statement
Testing and review