USWDS - Validation: Fix build failure for textarea validation#5795
Merged
Conversation
This was referenced Mar 1, 2024
amyleadem
approved these changes
Mar 1, 2024
amyleadem
left a comment
Contributor
There was a problem hiding this comment.
Thanks for submitting this fix!
I performed the following tests:
- Confirm the error is present on
developafter runningnpm run test:a11y - Confirm there are no errors on this branch after running
npm run test:ci - Confirm the “Textarea validation” story still behaves as expected
mahoneycm
approved these changes
Mar 1, 2024
mahoneycm
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for the quick fix 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a build failure currently on
developbranch affecting all pull requests, described at #5233 (comment) .Related pull requests
#5233
Testing and review
Build should pass.