[Test] Header padding fix#5665
Merged
amyleadem merged 5 commits intoDec 8, 2023
Merged
Conversation
added 3 commits
December 6, 2023 13:20
…ical-center-nav-padding-fix
…om/uswds/uswds into cm-vertical-center-nav-padding-fix
…om/uswds/uswds into al-vertical-center-nav-padding-fix
mahoneycm
approved these changes
Dec 8, 2023
mahoneycm
left a comment
Contributor
There was a problem hiding this comment.
Thank you so much for working this fix out! Looks great across multiple sizes, mobile and header.
- Links and buttons spans maintain vertical alignment
- Links and buttons maintain the same size despite line breaks
- Icons maintain vertical alignment
- Mobile styles unaffected
- Nav bars with additional buttons maintain uniform styles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview link
Preview link
Notes
This branch pulled in the most recent updates from
develop, so unfortunately the files changed might be confusing, but these should be the relevant updates:Screenshots
Single line (Vertically aligned in both)
Mismatched heights/multiple lines (develop does not have vertical center alignment)
