USWDS - Utilities: Add "full-percent" palettes to top, left, right#5633
Merged
Conversation
Contributor
|
@amyleadem two questions;
|
Contributor
Author
|
mejiaj
approved these changes
Nov 21, 2023
mejiaj
left a comment
Contributor
There was a problem hiding this comment.
Thanks for addressing this
mahoneycm
approved these changes
Nov 27, 2023
mahoneycm
left a comment
Contributor
There was a problem hiding this comment.
Works like a charm!
- Pattern matches
bottom-fullwhich previously worked - Correctly adds
top,left, andrightrelative positioning
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a bug that prevented the CSS from generating
.left-full,.right-full, and.top-fullutility classes.Breaking change
This is not a breaking change.
Related issue
Closes #5632
Related pull requests
Changelog PR
Problem statement
Our documentation for
.left-,.right-, and.top-utility classes state that USWDS offers.left-full,.right-full, and.top-fullclasses. However, these do not appear in the default USWDS CSS. USWDS CSS does currently provide a.bottom-fullclass.Solution
Added "full-percent" palettes to
.top-,.left-,.right-utility classes.Testing and review
.left-full,.right-full, and.top-fullclasses..left-full,.right-full, and.top-fullclasses.