USWDS - Outline: Fix broken outline-05 utility#5079
Merged
Conversation
mejiaj
approved these changes
Jan 27, 2023
mejiaj
left a comment
Contributor
There was a problem hiding this comment.
Nice and straightforward fix, thank you!
mahoneycm
approved these changes
Jan 27, 2023
thisisdano
approved these changes
Feb 28, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a compilation bug in the
outlineutility so that it can accept the '05' spacing token. Now, the.outline-05utility class andu-outline('05')mixin should work as expected.Breaking change
This is not a breaking change.
Related issue
Closes #5078
Problem statement
The outline utility was not able to read
spacing-multiple(05), which resulted in a CSS error and improper display.Solution
Adding
@use "./functions/units/spacing-multiple" as *;to the top of_properties.scssgives the file what it needs to process thespacing-multiple()function.Testing and review
To test, confirm that the following work as expected:
outline-05utility classu-outline('05')mixinu-outline(0.5)mixin