USWDS - Input: Remove top margin from error inputs. Resolves #4189#4751
Merged
Conversation
4 tasks
mejiaj
approved these changes
Jun 2, 2022
mejiaj
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks Charlie.
amyleadem
approved these changes
Jun 3, 2022
amyleadem
left a comment
Contributor
There was a problem hiding this comment.
Looks good! And thanks for the videos!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4189
Removes defined top margin from
usa-form-group--errorso that it inheritsusa-form-grouptop margin. This prevents the input from shifting vertically when the error state is initiated.Additional information
Before:
error-margin.mov
After:
Screen.Recording.2022-05-31.at.4.44.39.PM.mov
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.