USWDS - global: Fix normalize.css precedence#4726
Merged
thisisdano merged 1 commit intodevelopfrom Jun 3, 2022
Merged
Conversation
4 tasks
mejiaj
approved these changes
May 27, 2022
thisisdano
approved these changes
Jun 3, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #4698
Problem:
When either the
$theme-global-content-stylesor$theme-global-paragraph-stylessettings are set to true, styles from normalize.css take precedence over some USWDS global typography styles . Because normalize.css is reset CSS, it should not take precedence over any USWDS styles.This issue is demonstrated with vertical margin issues between text elements (outlined in #4698)
Solution:
This precedence issue is happening because normalize CSS is not compiling at the top of the file:
Because normalize does not reside at the top of the compiled file, it can take precedence over any compiled USWDS styles that come before it.
Moving the
@forwardreferences fornormalizeaboveuswds-corewill reorder the compiled CSS, and bring normalize to the top of the file.Testing:
$theme-global-content-stylestotrueuswds.cssmargin-top: 0andmargin-bottom: 0<button>should havemargin-top: 1emAdditional information
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.