Remove polyfills from USWDS 3#4692
Conversation
|
On close inspection of our JavaScript bundles, I also noticed that USWDS packages a few additional polyfills transitively through the |
070d593 to
d561895
Compare
Since Internet Explorer is no longer supported in the next major release (uswds#4538), polyfills which exist to add support for the browser should be removed.
d561895 to
85236ee
Compare
|
Accidental approval, flagging for re-review |
mahoneycm
left a comment
There was a problem hiding this comment.
This looks good to me!
- Methods meet baseline requirements
- All references to polyfills removed
- No perceived regressions
- Code meets standards
- No regression with
Behavior- Spreading the
propsparam prevents init issues
- Spreading the
- No regression with
focus-trap - No perceived regressions when installed on site
@aduth can you resolve the merge conflicts when you have the chance?
|
Question: Would it be a good idea to remove references to the polyfills from our README ? Line 57 in ae7129c Line 515 in ae7129c CC: @mejiaj @amyleadem |
mejiaj
left a comment
There was a problem hiding this comment.
Thanks for this contribution, it's nice to see these finally getting removed!
Re: README
@mahoneycm that's a good note. We'll need to update the docs before the official release.
Description
This pull request removes polyfills aimed at supporting Internet Explorer.
Additional information
Since Internet Explorer is no longer supported, polyfills which exist to add support for the browser should be removed.
Benefit for users: USWDS is as lean as it can be to avoid unnecessary excessive load times.
Benefit for developers: Fewer dependencies means faster install times and lower surface area risk for security vulnerabilities.
See related browser compatibility:
CustomEventHTMLElement#hiddenNumber.isNaNObject.assignElement#classListPerformance comparison:
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.