Merged
Conversation
4 tasks
mejiaj
approved these changes
May 12, 2022
Contributor
mejiaj
left a comment
There was a problem hiding this comment.
Icons look good and I don't see visual problems with the icons, how the spritesheet is compiled, or using icons from sprite.
I did notice some icons had their ID's removed. This probably won't be a problem since the IDs seemed to be inconsistently used.
Contributor
|
This issue appears to have existed prior to this PR, and not sure if it can/should be resolved here, but wanted to flag that
Edit: Created issue #4752 to track this issue in case this isn't the appropriate place to solve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the SVGO defaults to normalize and compress all USWDS SVGs. Our config maintains both the
height/widthandviewBox.height="24"andwidth="24"for some icons that were missing itsvgo@2.8.0as a dependencyFixes #4306